Repository navigation
feat(notifications): notify on failed workflow branches and name the failed run - #403
Merged
Merged
Conversation
…failed run Generation and full workflow runs already raised an OS notification on error, but a Wait branch started with Continue that failed stayed silent, and every error toast dumped the raw String(err) with no context. - Extract buildRunErrorNotification(): no toast for a user cancellation, otherwise "<model id | workflow name>: <first line of the error>", generic "Error: " prefix stripped, truncated to 120 chars - Notify when a workflow branch (continueRun) fails - Skip the generation error toast if the user cancelled while the last status poll was in flight - Same focus gating and click-to-focus behaviour as completion toasts Closes #293
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #293
Context
Most of #293 was already on dev: commit f3a7014 added error toasts for single generations and full workflow runs. This PR closes the remaining gaps.
Changes
finishBranchreturns early when the run was cancelled).<model id | workflow name>: <first line of the error>. A plainError:prefix is stripped, but specific ones likeRuntimeError:are kept. The body is cut to 120 characters, and an empty error becomes "Unknown error".showErrorNotificationis replaced byshowRunErrorNotification(input), built on a purebuildRunErrorNotification(). Same focus check and click-to-focus behaviour as the completion toast.Test plan
notification.test.ts(new): 7/7workflowSceneRun.test.mjs: passnpm test, full suite) passed